-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: path construction errors on Windows #19
Conversation
I can't seem to figure out the integration tests. It must be the paths somewhere but I am not sure where |
the integration tests are snapshotted against linux output—looks like windows gives slightly different error messages |
There are error code 123 file path invalid errors: I suspect path construction is breaking somewhere |
Lines 44 to 47 in 1c991af
an input
was turned into
which then fails Line 155 in 1c991af
hmm looks like this is expected |
this is an invalid dir in windows |
ead88ee
to
f19d051
Compare
@suo I think I fixed it. Please take a look. Thanks! |
LGTM, thanks! I'd love to get the windows tests enabled at some point but it shouldn't block for now. |
fixes #18