feat: a tool to convert json output to SARIF format #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinchuby
changed the title
|
lgtm! Mind including a little test that runs it on an example lintrunner json result? |
|
Sure! Looks like CI is failing for some reason I couldn't understand |
|
Looks like this PyO3/maturin-action#99. I'll see if I need to pull down any changes to fix it |
|
I added a test. LMK if you want it done differently! |
|
can you rebase this change? The test thing should be fixed |
justinchuby
force-pushed
the
justinchuby/sarif
branch
from
f5ae005 to
4221e5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A tool that converts lintrunner json output to SARIF format, compatible with Github code scanning.
justinchuby/lintrunner-adapters#4
Screenshots: