-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass in segments keyword to the DRMS to return the SUMS dirs #7469
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, as long as the relevant online tests pass
Only failing test is: FAILED ../../.tox/py312-online/lib/python3.12/site-packages/sunpy/net/vso/vso.py::sunpy.net.vso.vso.VSOClient.search |
Given this, should we have an example that shows how to do that, maybe including how to build a header from the metadata and do the stitching together of the file yourself? |
I don't know if it's possible yet. You want it in this PR? |
No, I think its fine to leave it to another PR. |
8ea1820
to
205828b
Compare
Online fail is: FAILED ../../.tox/py312-online/lib/python3.12/site-packages/sunpy/io/tests/test_filetools.py::test_write_file_fits[aia_171_image.fits] - FileNotFoundError: [Errno 2] No such file or directory: 'aia_171_image.fits' |
Supersedes #7236
So the data on the JSOC is stored in SUM directories and they can return these locations to a user. To return this information, we just have to add a value for the
seg
key for the DRMS client.The reason we will want to do this is that it allows a user (and in future the JSOCClient) to use these file locations to download the JSOC data without having to export. The JSOC has asked sunpy to stop doing exports and this is step 1 of that process.