Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in segments keyword to the DRMS to return the SUMS dirs #7469

Merged
merged 6 commits into from
Mar 21, 2024

Conversation

nabobalis
Copy link
Contributor

Supersedes #7236

So the data on the JSOC is stored in SUM directories and they can return these locations to a user. To return this information, we just have to add a value for the seg key for the DRMS client.

The reason we will want to do this is that it allows a user (and in future the JSOCClient) to use these file locations to download the JSOC data without having to export. The JSOC has asked sunpy to stop doing exports and this is step 1 of that process.

@nabobalis nabobalis requested a review from a team as a code owner March 2, 2024 04:27
changelog/7469.feature.rst Outdated Show resolved Hide resolved
@wtbarnes wtbarnes added the net Affects the net submodule label Mar 7, 2024
@wtbarnes wtbarnes added the Merge When CI Passes Hit that merge button when it's all green! label Mar 7, 2024
Copy link
Member

@wtbarnes wtbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, as long as the relevant online tests pass

@nabobalis
Copy link
Contributor Author

Only failing test is:

FAILED ../../.tox/py312-online/lib/python3.12/site-packages/sunpy/net/vso/vso.py::sunpy.net.vso.vso.VSOClient.search

@wtbarnes
Copy link
Member

The reason we will want to do this is that it allows a user (and in future the JSOCClient) to use these file locations to download the JSOC data without having to export. The JSOC has asked sunpy to stop doing exports and this is step 1 of that process.

Given this, should we have an example that shows how to do that, maybe including how to build a header from the metadata and do the stitching together of the file yourself?

@nabobalis
Copy link
Contributor Author

I don't know if it's possible yet. You want it in this PR?

@wtbarnes
Copy link
Member

I don't know if it's possible yet. You want it in this PR?

No, I think its fine to leave it to another PR.

@wtbarnes wtbarnes added the Needs Review Needs reviews before merge. label Mar 14, 2024
sunpy/net/jsoc/jsoc.py Outdated Show resolved Hide resolved
@nabobalis nabobalis added Minor Change PR only needs one approval to merge. and removed Needs Review Needs reviews before merge. labels Mar 20, 2024
@nabobalis nabobalis force-pushed the segments branch 2 times, most recently from 8ea1820 to 205828b Compare March 20, 2024 23:48
sunpy/net/jsoc/jsoc.py Outdated Show resolved Hide resolved
@nabobalis
Copy link
Contributor Author

Online fail is: FAILED ../../.tox/py312-online/lib/python3.12/site-packages/sunpy/io/tests/test_filetools.py::test_write_file_fits[aia_171_image.fits] - FileNotFoundError: [Errno 2] No such file or directory: 'aia_171_image.fits'

@nabobalis nabobalis merged commit 2e61930 into sunpy:main Mar 21, 2024
25 of 27 checks passed
@nabobalis nabobalis added the No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) label Mar 21, 2024
@nabobalis nabobalis deleted the segments branch March 21, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge When CI Passes Hit that merge button when it's all green! Minor Change PR only needs one approval to merge. net Affects the net submodule No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants