get_horizons_coord() no longer uses astroquery
#7319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayshih
added
coordinates
Cadair
reviewed
Nov 23, 2023
ayshih
force-pushed
the
no_astroquery
branch
10 times, most recently
from
20f669a
to
e6229e9
Compare
Cadair
reviewed
Nov 28, 2023
ayshih
force-pushed
the
no_astroquery
branch
2 times, most recently
from
29de24b
to
4d00a4b
Compare
nabobalis
reviewed
Dec 6, 2023
nabobalis
approved these changes
Dec 6, 2023
|
Codecov left a bunch of comments but the patches passed so I am confused but don't care enough to dig down as to what happened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7080
This PR re-implements
get_horizons_coord()so that the function no longer usesastroquery. Consequently,astroqueryis no longer a library (optional) dependency, although it is still a dependency for building the gallery examples because we useastroqueryto get star positions in one example. This new implementation actually has two improvements:This PR adds
requestsas an explicit dependency for the core package, but sincerequestsis already an implicit dependency ofsunpy.net(viazeep) and of any environment for building docs (viasphinx), it has no impact on most actual environments.