-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add example for querying SHARP data and constructing a Map #6757
Conversation
Co-authored-by: Nabil Freij <[email protected]>
Co-authored-by: Nabil Freij <[email protected]>
I am not sure if the example runs, can you check that I didn't break it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor changes. The RTD preview has not rendered yet either and I'd like to take a brief look at that before approving.
Co-authored-by: Nabil Freij <[email protected]>
Co-authored-by: Will Barnes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I did not catch several things on first review, namely that the example does not work in its current state.
Co-authored-by: Will Barnes <[email protected]>
i think there mustn't be anymore changes left to make now? |
Have you checked if the example works and renders nicely on RTD? |
i built the docs on my system using |
This still needs a changelog. |
Co-authored-by: Will Barnes <[email protected]>
Co-authored-by: Will Barnes <[email protected]>
…data.py Co-authored-by: Will Barnes <[email protected]>
…data.py Co-authored-by: Will Barnes <[email protected]>
I will merge after I glance over the RTD version. |
Thanks @exitflynn for the example |
thank you so much for the reviews as well, Nabil and Will! 🤠 |
PR Description
Adds an example gallery entry for querying SHARP data and then constructing a Map. Closes #6663.