Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example for querying SHARP data and constructing a Map #6757

Merged
merged 18 commits into from
Feb 8, 2023

Conversation

exitflynn
Copy link
Member

PR Description

Adds an example gallery entry for querying SHARP data and then constructing a Map. Closes #6663.

@exitflynn exitflynn requested a review from a team as a code owner February 1, 2023 12:29
@nabobalis nabobalis added Examples Related to the Example Gallery. No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) labels Feb 1, 2023
examples/acquiring_data/working_with_SHARP_data.py Outdated Show resolved Hide resolved
examples/acquiring_data/working_with_SHARP_data.py Outdated Show resolved Hide resolved
examples/acquiring_data/working_with_SHARP_data.py Outdated Show resolved Hide resolved
examples/acquiring_data/working_with_SHARP_data.py Outdated Show resolved Hide resolved
examples/acquiring_data/working_with_SHARP_data.py Outdated Show resolved Hide resolved
examples/acquiring_data/working_with_SHARP_data.py Outdated Show resolved Hide resolved
examples/acquiring_data/working_with_SHARP_data.py Outdated Show resolved Hide resolved
examples/acquiring_data/working_with_SHARP_data.py Outdated Show resolved Hide resolved
examples/acquiring_data/working_with_SHARP_data.py Outdated Show resolved Hide resolved
@nabobalis
Copy link
Contributor

I am not sure if the example runs, can you check that I didn't break it?

Copy link
Member

@wtbarnes wtbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes. The RTD preview has not rendered yet either and I'd like to take a brief look at that before approving.

Copy link
Member

@wtbarnes wtbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I did not catch several things on first review, namely that the example does not work in its current state.

@exitflynn
Copy link
Member Author

i think there mustn't be anymore changes left to make now?

@nabobalis
Copy link
Contributor

Have you checked if the example works and renders nicely on RTD?

@exitflynn
Copy link
Member Author

exitflynn commented Feb 6, 2023

i built the docs on my system using sphinx-build and there was indeed a minor problem. all fixed now, everything looks good to me!

@wtbarnes
Copy link
Member

wtbarnes commented Feb 6, 2023

This still needs a changelog.

changelog/6757.doc.rst Outdated Show resolved Hide resolved
changelog/6757.doc.rst Outdated Show resolved Hide resolved
@nabobalis
Copy link
Contributor

I will merge after I glance over the RTD version.

@nabobalis nabobalis merged commit d02b683 into sunpy:main Feb 8, 2023
@nabobalis
Copy link
Contributor

Thanks @exitflynn for the example

@exitflynn
Copy link
Member Author

thank you so much for the reviews as well, Nabil and Will! 🤠

@exitflynn exitflynn deleted the sharks branch February 10, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Examples Related to the Example Gallery. No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an example gallery entry for querying SHARP data and constructing a Map
3 participants