Add method argument to rotate and affine_transform #5916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstansby
added
the
No Backport
|
Hello @dstansby! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! Comment last updated at 2022-02-25 10:38:29 UTC |
dstansby
force-pushed
the
rotate-method
branch
from
b610d4d
to
fd74da7
Compare
Cadair
reviewed
Mar 2, 2022
nabobalis
approved these changes
Mar 2, 2022
Cadair
approved these changes
Mar 3, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
use_scipyargument with themethodargument, allowing us more flexibility in howaffine_transformmethods are specified/implemented in the future.This is pulled out of https://github.com/sunpy/sunpy/pull/4502/files for easier review/discussion.