Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to AIA+EUVI coordinates examples #5534

Merged
merged 6 commits into from
Sep 22, 2021

Conversation

ayshih
Copy link
Member

@ayshih ayshih commented Sep 20, 2021

This PR fixes a number of issues I noted with coordinates examples that combine AIA and EUVI data (see #5529 (review))

Closes #5533

@nabobalis
Copy link
Contributor

I leave it you to you if you want to changelog it.

@ayshih
Copy link
Member Author

ayshih commented Sep 21, 2021

I won't bother with a changelog here because #5529 didn't either

@ayshih ayshih added the No Changelog Entry Needed Skip any changelog checks. label Sep 21, 2021
@ayshih
Copy link
Member Author

ayshih commented Sep 21, 2021

Incidentally, the position of the features in the AIA map don't exactly line up to the features on the EUVI map. There may be some issue with the metadata of one or both maps (observer location, plate scale, etc.).

@ayshih ayshih marked this pull request as ready for review September 21, 2021 14:46
@ayshih ayshih requested a review from a team as a code owner September 21, 2021 14:46
@ayshih
Copy link
Member Author

ayshih commented Sep 21, 2021

Incidentally, the position of the features in the AIA map don't exactly line up to the features on the EUVI map. There may be some issue with the metadata of one or both maps (observer location, plate scale, etc.).

It shouldn't block this PR, but here's a figure showing what I mean (the contours are from AIA transformed into the EUVI coordinate frame):
download (36)

@ayshih
Copy link
Member Author

ayshih commented Sep 21, 2021

The discrepancy is mostly due to the formation height of 304 A emission in the chromosphere, with the remaining discrepancy possibly due to inaccuracy in the reported pixel location of disk center in the EUVI metadata.

@nabobalis
Copy link
Contributor

I am not sure if this is an issue but:

https://sunpy--5534.org.readthedocs.build/en/5534/_images/sphx_glr_AIA_limb_STEREO_002.png
lacks a title? At least it is missing the EUVI 304 title from master.

@ayshih
Copy link
Member Author

ayshih commented Sep 22, 2021

Ah, whoops, forgot to check that. I pushed the title beyond the extent of the canvas, so I'll fix the figure size.

@Cadair
Copy link
Member

Cadair commented Sep 22, 2021

I feel like this is a cool change and should at least have a changelog entry?

@ayshih
Copy link
Member Author

ayshih commented Sep 22, 2021

I feel like this is a cool change and should at least have a changelog entry?

Okay, added

@ayshih ayshih removed the No Changelog Entry Needed Skip any changelog checks. label Sep 22, 2021
@nabobalis nabobalis merged commit 673e78c into sunpy:main Sep 22, 2021
@ayshih ayshih deleted the aia_examples branch September 22, 2021 16:14
# Move the title so it does not clash with the extra labels.
tx, ty = ax.title.get_position()
ax.title.set_position([tx, ty + 0.08])
# Crop the view
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Crop the view
# Crop the view using pixel coordinates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Stereo Examples to have better plots
3 participants