-
-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to AIA+EUVI coordinates examples #5534
Conversation
I leave it you to you if you want to changelog it. |
I won't bother with a changelog here because #5529 didn't either |
Incidentally, the position of the features in the AIA map don't exactly line up to the features on the EUVI map. There may be some issue with the metadata of one or both maps (observer location, plate scale, etc.). |
The discrepancy is mostly due to the formation height of 304 A emission in the chromosphere, with the remaining discrepancy possibly due to inaccuracy in the reported pixel location of disk center in the EUVI metadata. |
examples/units_and_coordinates/SDO_to_STEREO_Coordinate_Conversion.py
Outdated
Show resolved
Hide resolved
I am not sure if this is an issue but: https://sunpy--5534.org.readthedocs.build/en/5534/_images/sphx_glr_AIA_limb_STEREO_002.png |
Ah, whoops, forgot to check that. I pushed the title beyond the extent of the canvas, so I'll fix the figure size. |
I feel like this is a cool change and should at least have a changelog entry? |
Okay, added |
# Move the title so it does not clash with the extra labels. | ||
tx, ty = ax.title.get_position() | ||
ax.title.set_position([tx, ty + 0.08]) | ||
# Crop the view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Crop the view | |
# Crop the view using pixel coordinates |
This PR fixes a number of issues I noted with coordinates examples that combine AIA and EUVI data (see #5529 (review))
Closes #5533