Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix XRT TIMESYS keyword #5508

Merged
merged 2 commits into from
Aug 21, 2021
Merged

Fix XRT TIMESYS keyword #5508

merged 2 commits into from
Aug 21, 2021

Conversation

dstansby
Copy link
Member

This is needed to construct a valid WCS.

@dstansby dstansby requested a review from a team as a code owner August 18, 2021 13:04
@pep8speaks
Copy link

pep8speaks commented Aug 18, 2021 •
edited
Loading

Hello @dstansby! Thanks for updating this PR.

Line 17:17: E741 ambiguous variable name 'l'

Comment last updated at 2021-08-18 13:46:00 UTC

@dstansby dstansby added the Needs Review Needs reviews before merge. label Aug 18, 2021
@nabobalis nabobalis added the map Affects the map submodule label Aug 21, 2021
@nabobalis nabobalis merged commit 686a9c4 into sunpy:main Aug 21, 2021
@sunpy-backport sunpy-backport bot mentioned this pull request Aug 21, 2021
Merged
@dstansby dstansby deleted the xrt-timesys branch August 21, 2021 14:03
@dstansby dstansby removed the Needs Review Needs reviews before merge. label Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtbarnes wtbarnes wtbarnes approved these changes

Assignees
No one assigned
Labels
map Affects the map submodule
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dstansby @pep8speaks @wtbarnes @nabobalis