Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation on coordinates with velocities #4610

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Add documentation on coordinates with velocities #4610

merged 1 commit into from
Oct 28, 2020

Conversation

ayshih
Copy link
Member

@ayshih ayshih commented Oct 28, 2020

Coordinates with velocities are already supported. This closes #3188 by adding user documentation.

@ayshih ayshih added coordinates Affects the coordinates submodule Documentation labels Oct 28, 2020
@ayshih ayshih marked this pull request as ready for review October 28, 2020 17:19
@ayshih ayshih added the No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) label Oct 28, 2020
Cadair
Cadair approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads well to me 👍

@Cadair Cadair added this to the 2.1 milestone Oct 28, 2020
@Cadair Cadair merged commit 9b28beb into sunpy:master Oct 28, 2020
@ayshih ayshih mentioned this pull request Oct 30, 2020
Closed
6 tasks
@ayshih ayshih deleted the velocities.rst branch November 20, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis approved these changes

@Cadair Cadair Cadair approved these changes

Assignees
No one assigned
Labels
coordinates Affects the coordinates submodule No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

Properly support velocities in our coordinate frames
3 participants
@ayshih @Cadair @nabobalis