Fix ylim setting by LineAnimator #4554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanRyanIrish
force-pushed
the
line_animator_ylim_bugfix
branch
from
ca14650
to
0cde179
Compare
|
Could you use |
Bug occurred when some data in the array to be animated was not finite.
nabobalis
force-pushed
the
line_animator_ylim_bugfix
branch
from
0cde179
to
957fdb2
Compare
I have updated the PR with some tests. See if it is satisfactory. |
kakirastern
approved these changes
Nov 15, 2020
hayesla
approved these changes
Nov 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug which occurs in setting the ylims by
LineAnimatorwhen there are non-finite values in the data array to be animated.