Drop support for Python 3.6 #4284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
approved these changes
Jun 13, 2020
nabobalis
added
the
Infrastructure
|
Needs a changelog. |
dstansby
reviewed
Jun 15, 2020
| - py36_test_oldestdeps | ||
| - py36_conda | ||
| - py38_test_oldestdeps | ||
| - py38_conda |
There was a problem hiding this comment.
Is the whole test suite run on py38_conda? If so it seems a bit of a waste given there's already a set of tests run on py38_test.
There was a problem hiding this comment.
yeah, it needs to run the whole test suite. We could, but I am not sure I want to swap the conda build to macos to remove the duplication but I would rather keep them separate.
|
Now also bumping our other core versions. Matplotlib, scipy and pandas are now at the major version released two years before our scheduled 2.1 release (so ~Nov/Dec). Astropy gets its regular bump, so we are now at 4.0. Numpy is bumped in line with NEP 29, but also the minimum version in astropy 4.0. |
Cadair
force-pushed
the
remove_3.6
branch
2 times, most recently
from
5f6d2c8
to
adae3de
Compare
nabobalis
reviewed
Jun 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the master branch version of #4283 seeing how it was "broken" anyway, we might as well drop it rather than fix it.