Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing bug in Fido to allow download to path="./" #4058

Merged
merged 5 commits into from
Apr 29, 2020
Merged

Fixing bug in Fido to allow download to path="./" #4058

merged 5 commits into from
Apr 29, 2020

Conversation

hayesla
Copy link
Member

@hayesla hayesla commented Apr 27, 2020

Description

Small fix to bug within fido_factory.py to allow download to path = "./" in Fido.fetch().

I think I might need some help/advice on the test written for this using the pytest tmpdir or tmp_path

Fixes #
#4057

@hayesla hayesla requested a review from a team as a code owner April 27, 2020 21:16
@nabobalis nabobalis added this to the 2.0 milestone Apr 27, 2020
@pep8speaks
Copy link

pep8speaks commented Apr 28, 2020 •
edited
Loading

Hello @hayesla! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-04-29 14:41:45 UTC

@hayesla
Copy link
Member Author

hayesla commented Apr 28, 2020

does this need a changelog?

@nabobalis
Copy link
Contributor

I think it does since its a bugfix.

Cadair
Cadair reviewed Apr 29, 2020
View reviewed changes
changelog/4058.bugfix.rst Outdated Show resolved Hide resolved
@dstansby
Copy link
Member

I just fixed the PEP8

dstansby
dstansby approved these changes Apr 29, 2020
View reviewed changes
sunpy/net/tests/test_fido.py Show resolved Hide resolved
@nabobalis nabobalis merged commit dacb05b into sunpy:master Apr 29, 2020
@sunpy-backport sunpy-backport bot mentioned this pull request Apr 29, 2020
Merged
@nabobalis nabobalis added backport 1.1 Still Needs Manual Backport This PR needs manually backporting. and removed backport 1.1 labels Apr 30, 2020
@sunpy-backport sunpy-backport bot mentioned this pull request Apr 30, 2020
Merged
@nabobalis nabobalis removed the Still Needs Manual Backport This PR needs manually backporting. label Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtbarnes wtbarnes wtbarnes left review comments

@dstansby dstansby dstansby approved these changes

@nabobalis nabobalis nabobalis left review comments

@Cadair Cadair Cadair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@hayesla @pep8speaks @nabobalis @dstansby @Cadair @wtbarnes