Fixing differential rotation of coordinates again. #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fa5969b.
|
Hello @wafels! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-05-22 15:32:39 UTC |
|
Thanks for the pull request @wafels! Everything looks great! |
added 2 commits
May 22, 2019 00:53
Cadair
reviewed
May 22, 2019
| heliographic_rotated = SkyCoord(heliographic_coordinate.lon + drot, | ||
| heliographic_coordinate.lat, | ||
| heliographic_coordinate.radius, | ||
| obstime = new_observer.obstime, |
There was a problem hiding this comment.
no spaces around kwarg = please.
Cadair
approved these changes
May 22, 2019
|
@nabobalis backport please. |
|
This and the warping code in #2972 can be used to reproject images to different viewpoints. |
|
Can I just protest about the history? |
|
Me thinks we might have to give @wafels a lesson on rewriting git history 😛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the differential rotation of coordinates again. With this PR, the
solar_rotate_coordinatefunction returns a coordinate that accounts for the location of thenew_observer.Fixes #