Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new example for getting colormaps #2865

Merged
merged 5 commits into from
Jan 9, 2019
Merged

Added new example for getting colormaps #2865

merged 5 commits into from
Jan 9, 2019

Conversation

ehsteve
Copy link
Member

@ehsteve ehsteve commented Dec 10, 2018 •
edited by nabobalis
Loading

Description

Provide a simple example to get at the SunPy colormaps and using them with matplotlib

@pep8speaks
Copy link

pep8speaks commented Dec 10, 2018 •
edited
Loading

Hello @ehsteve! Thanks for updating the PR.

Line 25:1: E402 module level import not at top of file

Comment last updated on January 09, 2019 at 11:53 Hours UTC

@ghost
Copy link

ghost commented Dec 10, 2018 •
edited by ghost
Loading

Thanks for the pull request @ehsteve! Everything looks great!

@Cadair Cadair added this to the 1.0 milestone Dec 10, 2018
@nabobalis nabobalis added the Examples Related to the Example Gallery. label Jan 7, 2019
@nabobalis
Copy link
Contributor

nabobalis commented Jan 9, 2019 •
edited
Loading

So I rebased and decided that we also do not need the reference colormap example. I added it to the new example.

Since the CI is on fire, the only build we care about is the docs one.

Looks good to me.
https://5706-2165383-gh.circle-artifacts.com/0/root/project/docs/_build/html/generated/gallery/plotting/sunpy_matplotlib_colormap.html#sphx-glr-generated-gallery-plotting-sunpy-matplotlib-colormap-py

@Cadair
Copy link
Member

Cadair commented Jan 9, 2019

Can we set the second image (the one with all the colourmaps) as the thumbnail? i.e. https://sphinx-gallery.readthedocs.io/en/latest/auto_examples/plot_choose_thumbnail.html

@nabobalis
Copy link
Contributor

And like magic.

@nabobalis nabobalis added No Changelog Entry Needed Skip any changelog checks. and removed No Changelog Entry Needed Skip any changelog checks. labels Jan 9, 2019
@ghost
Copy link

ghost commented Jan 9, 2019 •
edited by ghost
Loading

Thanks for the pull request @ehsteve! Everything looks great!

@Cadair Cadair merged commit 6d0ebdb into sunpy:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabobalis nabobalis nabobalis approved these changes

@Cadair Cadair Cadair approved these changes

Assignees
No one assigned
Labels
Examples Related to the Example Gallery.
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ehsteve @pep8speaks @nabobalis @Cadair