Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submap no longer correctly interprets the bottom left and top right corners in world coordinates #4725

Closed
Cadair opened this issue Dec 11, 2020 · 0 comments · Fixed by #4727
Closed

Submap no longer correctly interprets the bottom left and top right corners in world coordinates #4725

Cadair opened this issue Dec 11, 2020 · 0 comments · Fixed by #4727
Labels
Affects Dev An issue/bug that affects master Affects Release An issue/bug that affects a released version (use a version label too) Effort Medium Requires a moderate time investment. map Affects the map submodule Priority High Rapid action required.
Milestone
2.1

Comments

@Cadair
Copy link
Member

Cadair commented Dec 11, 2020

To save myself typing it out again, this bug is demonstrated in this notebook: https://gist.github.com/Cadair/9c14a3224efebb46aff02eb0ba629a7f

The behaviour in 1.0 is shown here: https://gist.github.com/bd632ca84c5cc566c3488d19096f876f
@Cadair Cadair added Bug(?) map Affects the map submodule Affects Release An issue/bug that affects a released version (use a version label too) Priority High Rapid action required. Effort Medium Requires a moderate time investment. labels Dec 11, 2020
@Cadair Cadair added this to the 2.1 milestone Dec 11, 2020
@nabobalis nabobalis added the Affects Dev An issue/bug that affects master label Dec 11, 2020
@Cadair Cadair mentioned this issue Dec 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Affects Dev An issue/bug that affects master Affects Release An issue/bug that affects a released version (use a version label too) Effort Medium Requires a moderate time investment. map Affects the map submodule Priority High Rapid action required.
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

Fix submap not using all four corners of the input rectangle Cadair/sunpy
2 participants
@Cadair @nabobalis