Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Affiliated Package Review Request: XRTpy #431

Closed
7 tasks done
joyvelasquez opened this issue Aug 23, 2024 · 5 comments · Fixed by #433
Closed
7 tasks done

Affiliated Package Review Request: XRTpy #431

joyvelasquez opened this issue Aug 23, 2024 · 5 comments · Fixed by #433
Assignees
Labels
Affiliated Package Review An issue submitting a new Affiliated Package for review

Comments

@joyvelasquez
Copy link

joyvelasquez commented Aug 23, 2024

Package Details

Description of Package

XRTpy is a Python package developed to facilitate the analysis of observations from the X-Ray Telescope (XRT) aboard the Hinode spacecraft. It provides specialized tools for processing high-resolution solar corona images and diagnosing coronal temperatures, supporting the research needs of the solar physics community.

Package Review

Editor Submission Checklist

  • Is the submission appropriate (compatible with the SunPy CoC)?
  • Does the project have an appropriate license?
  • Is the project in an online version control system?
  • Does the project provide a Python interface?
  • Is the project on PyPI?
  • Is the project useful to the solar physics community?
  • Version that was reviewed (tag or commit hash) - v0.4.1

Instructions to Reviewer

Please copy the following and select the ranking for each criteria, the full review criteria can be found here:

* Functionality           : General Package / Specialized Package / Not Relevant
* Integration             : Well integrated / Partially Integrated / Minimal Integration
* Documentation           : Extensive / Some / Little
* Testing                 : Excellent / Good / Needs Work
* Duplication             : None / Some / Major
* Community               : Excellent / Good / Needs Work
* Development Status      : Stable / Subject to Change / Low Activity / Needs Work
@joyvelasquez joyvelasquez added the Affiliated Package Review An issue submitting a new Affiliated Package for review label Aug 23, 2024
@wtbarnes
Copy link
Member

@Cadair Are you up for reviewing this submission?

@Cadair
Copy link
Member

Cadair commented Aug 26, 2024

yep

@Cadair
Copy link
Member

Cadair commented Aug 26, 2024

  • Functionality : Specialized Package
  • Integration : Well integrated
  • Documentation : Some
  • Testing : Good
  • Duplication : None
  • Community : Needs Work
  • Development Status : Subject to Change

Hi @joyvelasquez thanks a lot for submitting this. If you can add a Code of Conduct (HinodeXRT/xrtpy#10) then I can bump the community rating up and we can add XRTPy to the list.

@joyvelasquez
Copy link
Author

joyvelasquez commented Aug 28, 2024

Hello @Cadair, we've successfully created and merged a Code of Conduct for xrtpy. You can review the details in PR # 278: HinodeXRT/xrtpy#278.

@Cadair
Copy link
Member

Cadair commented Sep 2, 2024

Thanks, @joyvelasquez here's my final review. Let me know if you have any questions or comments. I shall open a PR to add you to the table later in the week.

  • Functionality : Specialized Package
  • Integration : Full
  • Documentation : Some
  • Testing : Good
  • Duplication : None
  • Community : Good
  • Development Status : Subject to Change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affiliated Package Review An issue submitting a new Affiliated Package for review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants