-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of sklearn.linear_model.ElasticNet
#35
Comments
sklearn.linear_model.ElasticNet
i can work on it |
Hello @advait-zx, you are welcome to try this but I think an issue like this requires some knowledge of sunkit-dem but also the use case for this library. So it might be a tricky issue for someone who is new. |
well, I can give it a try |
Sure. Good luck! I can try to help but this package is pretty left on its own these days. Not many people are aware of how or if it even works. |
what kind of Proposed solution is needed and also mention specific requirment |
That is a great question. I think first you'll need to figure how on earth someone uses this library. Does that help in anyway? |
I didn't have a proposed solution for this. I would first look at the paper and understand what they're doing. There are a few issues that we need to resolve for this package in general. I have a working understanding of the implementation by @wtbarnes, but this package needs dedicated dev time. Once a single DEM method is implemented, the others should be straight forward as it utilises the factory method. This was an initial idea of a simple-to-implement approach that doesn't require coding up the minimisation problem |
There isn't really an existing implementation you can follow in the package which is really too early of a stage to get to grips with. For some reason I don't have write to this repo but this issue should probably have been tagged with expert package knowledge and solar physics knowledge. You are obviously still welcome to go for it if you are confident. |
Can you tag this, I don't have permission |
Describe the feature
One of the most simple examples could be to implement an interface with
sklearn.linear_model.ElasticNet
: https://scikit-learn.org/stable/modules/generated/sklearn.linear_model.ElasticNet.html as used in https://iopscience.iop.org/article/10.3847/1538-4357/ad1837#apjad1837f5Proposed solution
No response
The text was updated successfully, but these errors were encountered: