generate_atom_feeds() raises StopIteration

[baylessj]

Original issue was opened on Sphinx as sphinx-doc/sphinx#6722

The offending line is this:

ablog/ablog/post.py

Line 607 in d148cf4

url = blog.blog_baseurl

Not entirely sure what causes the url to be None, I'll do some more digging to see if it's an issue with my project's configuration or not. My hunch is that it is due to my combination of Python version and OS, the other developers on my team are able to build fine.

Project

https://github.com/purduesigbots/pros-docs

Software Versions

• Python: 3.7.3
• OS: Pop!_OS 19.04

[nabobalis]

What version of ablog are you using? Can you try with master? It is a Python 3 only version that I hopefully plan to release this year.

[baylessj]

0.9.4, I'll upgrade to 0.9.5 and see if that solves the issue.

[baylessj]

Upgraded, issue still occurs. Will look more into the cause.

[nabobalis]

You will have to install the version from master, its 0.10dev.

[baylessj]

Makes sense. Installed from source, version num is now 0.9.6.dev2+gd148cf4. Still getting the same error output.

[baylessj]

Adding the blog_baseurl string to the conf.py for the project stopped the error, which is good. I was not under the impression from ablog's documentation that this was a required parameter though, and I hadn't noticed this being necessary before, so that is odd. Should I consider this option to be a required option for ablog usage, or is something else causing this symptom?

[nabobalis]

Yeah it probably should be.

[nabobalis]

Actually now I recall. I think there is an open PR to fix this.

[baylessj]

Are you referring to #38? That seems related, but I can't really tell from the modifications to the code there if it adds a default baseurl value or if it requires the value

[nabobalis]

If I recall, I think it makes it require it.

[nabobalis]

There probably should be a base default

[baylessj]

I agree, a default would be nice to have. I'm not particularly interested in having an atom feed in my project's blog and it would be nice to not have to specify additional options for that.

Looks like jekyll just sets the baseurl value in their conf file to an empty string, do you think the same approach would work here?

[nabobalis]

Well it's better than being None

[baylessj]

Agreed. I can open a PR for this if you'd like, or would you prefer that this modification be a part of #38?

[nabobalis]

Probably makes more sense to be part of #38, could you leave a comment on that PR about this?