Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in fontawesome_link_cdn handling at install time #35

Closed
PhilipMay opened this issue Aug 10, 2019 · 1 comment · Fixed by #46
Closed

Bug in fontawesome_link_cdn handling at install time #35

PhilipMay opened this issue Aug 10, 2019 · 1 comment · Fixed by #46
Labels

Comments

@PhilipMay
Copy link

PhilipMay commented Aug 10, 2019

When I use ablog start and say I want to have fontawesome then abog generates this line in conf.py: fontawesome_link_cdn = True

This leads to this line in the generated html code: <link href="True" rel="stylesheet">

This is a bug...

Thanks
Philip

@nabobalis nabobalis added the Bug label Aug 10, 2019
@rayalan
Copy link
Contributor

rayalan commented Aug 18, 2019

Some quick notes on this:

  1. The primary issue looks like documentation isn't clear that this value should be the url location of the CDN, not true.
  2. A secondary issue is that there's minimal validation of config values, so there's not much warning or visibility of something is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants