From a021893bf132449ddfdb9dedb48ca5ac35ad02c0 Mon Sep 17 00:00:00 2001 From: sumukhswamy Date: Wed, 4 Sep 2024 10:54:57 -0700 Subject: [PATCH] asddressed comments Signed-off-by: sumukhswamy --- public/components/notebooks/components/main.tsx | 2 +- public/components/notebooks/components/note_table.tsx | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/public/components/notebooks/components/main.tsx b/public/components/notebooks/components/main.tsx index d140e0984c..e837cfb6d9 100644 --- a/public/components/notebooks/components/main.tsx +++ b/public/components/notebooks/components/main.tsx @@ -106,7 +106,7 @@ export class Main extends React.Component { console.error('Issue in fetching the notebooks', err.body.message); }); } else { - // If `MDS` is not enabled, fetch from both endpoints and combine the data. + // If `MDS` is not enabled /savedNotebook/ API returns notebooks stored as saved objects, and the other one returns notebooks stored as observability objects. return Promise.all([ this.props.http.get(`${NOTEBOOKS_API_PREFIX}/savedNotebook/`), this.props.http.get(`${NOTEBOOKS_API_PREFIX}/`), diff --git a/public/components/notebooks/components/note_table.tsx b/public/components/notebooks/components/note_table.tsx index 8e21b90264..4cce6e9f4f 100644 --- a/public/components/notebooks/components/note_table.tsx +++ b/public/components/notebooks/components/note_table.tsx @@ -22,7 +22,7 @@ import { EuiSpacer, EuiTableFieldDataColumnType, EuiText, - EuiTitle + EuiTitle, } from '@elastic/eui'; import truncate from 'lodash/truncate'; import moment from 'moment'; @@ -41,7 +41,7 @@ import { } from '../../../../common/constants/notebooks'; import { UI_DATE_FORMAT } from '../../../../common/constants/shared'; import { setNavBreadCrumbs } from '../../../../common/utils/set_nav_bread_crumbs'; -import { HeaderControlledComponentsWrapper } from '../../../../public/plugin_headerControl'; +import { HeaderControlledComponentsWrapper } from '../../../../public/plugin_helpers/plugin_headerControl'; import { coreRefs } from '../../../framework/core_refs'; import { DeleteNotebookModal, @@ -186,7 +186,6 @@ export function NoteTable({ getSampleNotebooksModal( closeModal, async () => { - console.log(selectedDataSourceId, selectedDataSourceLabel); closeModal(); await addSampleNotebooks(selectedDataSourceId, selectedDataSourceLabel); },