Use vite for dev #164
Merged
Use vite for dev #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems fine to me but here are some changes from the previous PR so that should be merged first |
mst101
force-pushed
the
tools/use-vite-for-dev
branch
5 times, most recently
from
3414623
to
5cfef6d
Compare
|
@mst101 with the jest update this one got some conflicts |
mst101
force-pushed
the
tools/use-vite-for-dev
branch
from
5cfef6d
to
c02da06
Compare
|
@MrWook - yay! Hope this one should be ok now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This (at least) allows us to use vite to run the Demo pages while we're developing the vue 2 branch.
I reworked some of your 'vue3-support' code @MrWook to get the vite build process to work, but then abandoned the idea once I discovered that @vitejs/plugin-legacy is not compatible with vue2.
I also had a go at setting up vitest as an alternative to jest, but it seems that vitest uses a different coverage tool to jest (c8 instead of nyc) and this caused some inconsistencies in the reports. There is a debate going on currently within vitest as to whether to give the choice between c8 and nyc, but until that's resolved, I suspect we're probably best off sticking with jest.
As you can see I tried to upgrade jest to the latest version, but that failed because node 10 doesn't like
globalThis.Oh well, guess I'll get back to upgrading to vue 3...