-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add prop to determine first-day-of-week #41
Conversation
OK @MrWook - I made a silly error when copying across the logic for the blank days and have fixed that in a second commit. Should all be fine now. I'd be grateful if you could have a look through and merge it in to master. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I just found some small issues.
Could you add an example on the example/demo.vue
and in the docs docs/.vuepress/components/demo.vue
with a settings selector to define the first-day-of-week?
Like always thanks for you contribution! 👍
Thanks for checking this through. |
You can just create a new commit, i will squash same anyway. |
Ok thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be great to also add this 'breaking change' in the Migration section: https://sumcumo.github.io/vue-datepicker/guide/Migration/
That the prop is replaced with this new prop.
Hey @sebsobseb i will create a complete Migration guide to get from 2.x.x to 3.x.x |
@MrWook - how would you like me to proceed with pull requests for: a) fixing a small bug with the typeable calendar not formatting correctly onblur Shall I wait until you have merged the current changes into master, or create a new branch from the current status of my |
@mst101 the best approach is if you make a branch and a PR for each topic. In this repo the example for the demo page and the example demo page is still missing. If you like you can already start with the other stuff, too. You don't need to wait for me. You just need to keep in mind that you probably need to resolve Merge conflicts this way. |
OK thanks - in that case, I'll create a new commit with |
No description provided.