-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade PHPUnit and add PHP 8.4 to CI #134
Merged
wachterjohannes
merged 13 commits into
sulu:0.x
from
alexander-schranz:feature/php-upgrade
Jul 25, 2024
Merged
Upgrade PHPUnit and add PHP 8.4 to CI #134
wachterjohannes
merged 13 commits into
sulu:0.x
from
alexander-schranz:feature/php-upgrade
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/php-upgrade
branch
from
July 25, 2024 09:26
b8389ee
to
1947bf9
Compare
Prokyonn
approved these changes
Jul 25, 2024
Prokyonn
approved these changes
Jul 25, 2024
wachterjohannes
approved these changes
Jul 25, 2024
@wachterjohannes feel free to create a tag whatever which one make sense for you (minor or patch) release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This not only add PHP 8.4 but also make sure that PHP 7.4 is tested on lowest Deps, in this case I stumbled over that Symfony 4.4 isn't working because message bus couldn't be initialized and so removed support for it.