Refactored product variant gateway and added handler to load stock of… #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… variant. Update Requirements and fixed codestyles and phpstan issues.
|
|
||
| public function getLocale(Request $request) | ||
| { | ||
| return $request->query->get('locale') ?? ''; |
There was a problem hiding this comment.
'' is a strange fallback here. this could lead to confusing behaviour. i think i would expect an error here if no locale is given
There was a problem hiding this comment.
Suggested change
| return $request->query->get('locale') ?? ''; | |
| $locale = $request->query->get('locale'); | |
| Assert::string($locale); | |
| return $locale; |
| @@ -80,6 +80,6 @@ public function getSecurityContext() | |||
|
|
|||
| public function getLocale(Request $request) | |||
| { | |||
| return $request->query->get('locale'); | |||
| return $request->query->get('locale') ?? ''; | |||
| @@ -29,8 +30,9 @@ protected function createProductInformation(string $productId, string $locale): | |||
| ] | |||
| ); | |||
|
|
|||
| /** @var ProductInterface $product */ | |||
There was a problem hiding this comment.
whats the reason for this? also i dont think that type is right, cant this be null too? 🤔
| @@ -29,7 +29,7 @@ protected function createProduct(string $code): Product | |||
| return $product; | |||
| } | |||
|
|
|||
| protected function findProduct(string $code): ?Product | |||
| protected function findProduct(string $code): ?object | |||
There was a problem hiding this comment.
whats the reason for this?
| @@ -75,10 +78,13 @@ protected function findProductInformation(string $id, string $locale): ?ProductI | |||
| ] | |||
| ); | |||
|
|
|||
| return $this->getEntityManager()->find( | |||
| /** @var ProductInformation $productInformation */ | |||
There was a problem hiding this comment.
Suggested change
| /** @var ProductInformation $productInformation */ | |
| /** @var ProductInformation|null $productInformation */ |
| @@ -95,13 +101,16 @@ protected function findProductInformationByCode(string $code, string $locale): ? | |||
| throw new \RuntimeException('Product not fount'); | |||
| } | |||
|
|
|||
| return $this->getEntityManager()->find( | |||
| /** @var ProductInformation $productInformation */ | |||
There was a problem hiding this comment.
Suggested change
| /** @var ProductInformation $productInformation */ | |
| /** @var ProductInformation|null $productInformation */ |
niklasnatter
approved these changes
Sep 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… variant. Update Requirements and fixed codestyles and phpstan issues.