Speech to text UI for media objects #1527
Conversation
peetucket
force-pushed
the
1524-start-stt
branch
from
ec1e5d0
to
de05e0f
Compare
| ocrEnabled () { | ||
| return this.data.get('ocr-enabled') === 'true' | ||
| } | ||
|
|
||
| sttEnabled () { | ||
| return this.data.get('stt-enabled') === 'true' | ||
| } |
There was a problem hiding this comment.
these enable the JS to see the Settings, which are passed into the stimulus controller
| @@ -180,7 +180,7 @@ def verify_output_dir_no_exists | |||
| def verify_file_manifest_selected_for_media | |||
| return unless content_structure == 'media' && !using_file_manifest | |||
|
|
|||
| errors.add(:content_structure, 'requires a file manifest. Please select the checkbox and ensure a file manifest is present.') | |||
| errors.add(:content_structure, 'requires a file manifest. Please indicate you have a file manifest and ensure a file manifest is present.') | |||
There was a problem hiding this comment.
fixes an existing error message, this control is no longer a checkbox, it is a radio button
| <div data-controller="globus <%= "caption" if Settings.ocr.enabled%>"> | ||
| <div data-controller="globus caption" | ||
| data-caption-stt-enabled="<%=Settings.speech_to_text.enabled%>" | ||
| data-caption-ocr-enabled="<%=Settings.ocr.enabled%>"> |
There was a problem hiding this comment.
always enable the caption stimulus controller and always add the controls to the html (but hidden)... we will instead make the settings values visible to the stimulus controller so the JS can do the work of deciding which controls to show/hide as needed based on feature flag settings and user selections
this makes it more flexible and easier to reason with (since it all happens in one place now, in the stimulus controller)
peetucket
force-pushed
the
1524-start-stt
branch
2 times, most recently
from
c136a79
to
de05e0f
Compare
| @@ -10,6 +10,7 @@ class StructuralBuilder | |||
| # @param [String] reading_order | |||
| # @param [Boolean] all_files_public | |||
| # @param [Boolean] manually_corrected_ocr set by user when creating the job | |||
| # @param [Boolean] ocr_available set by user when creating the job | |||
There was a problem hiding this comment.
noticed this missing param documentation
peetucket
changed the title
peetucket
changed the title
Why was this change made? 🤔
Fixes #1524 - allows the user to start speech to text for media object
HOLD for integration tests on stageAlso:
runOcrif it's false, that's the default). See https://github.com/sul-dlss/common-accessioning/blob/main/lib/dor/text_extraction/ocr.rb#L68-L71 for where we use the workflow context to decide if we need to run OCR (nil is that same as false)Note: shared_configs turns this in just in QA for now for testing.
Question:- since media objects always provide a file manifest, we may not need any of the changes in the fileset builder since it will never be used... and the user will be expected to provide sdrGenerated, corrected, etc. attributes for the files they provideHow was this change tested? 🤨
Spec
Integration test on stage