Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Custom modifier managers must define their capabilities #12

Closed
josemarluedke opened this issue Aug 20, 2019 · 7 comments
Closed

Custom modifier managers must define their capabilities #12

josemarluedke opened this issue Aug 20, 2019 · 7 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@josemarluedke
Copy link

Using the latest ember canary gives the following deprecation:

DEPRECATION: Custom modifier managers must define their capabilities using the capabilities() helper function [deprecation id: implicit-modifier-manager-capabilities]

@sukima
Copy link
Owner

sukima commented Aug 20, 2019

Do you know how to fix this? I am having troubles keeping up with all the churn on this.

@sukima sukima added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Aug 20, 2019
@josemarluedke
Copy link
Author

I believe that this PR can give some ideas on how to fix it: emberjs/ember-render-modifiers#13.

@sukima
Copy link
Owner

sukima commented Aug 20, 2019

This is more confusing then a three headed bunny rabbit on PCP. Sorry I have no idea what to do.

emberjs/ember-render-modifiers#13 (comment)

@sukima sukima removed the good first issue Good for newcomers label Aug 20, 2019
@sukima
Copy link
Owner

sukima commented Aug 20, 2019

@NullVoxPopuli
Copy link
Collaborator

NullVoxPopuli commented Sep 7, 2019

@sukima that branch eliminated the Deprecation warning for me, and all my tests still pass.

errr -- now I have doubt
image

@NullVoxPopuli
Copy link
Collaborator

here we go: #13

@chancancode
Copy link
Collaborator

This is fixed in v0.5.1 and v0.9.0!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants