diff --git a/CHANGELOG.md b/CHANGELOG.md index bfe198c..64041a7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,6 @@ === HEAD +* Remove support for `input` elements. * Revert to implicit-width, inline-block rendering. * Add variables support. * Use Component(1) for development. diff --git a/README.md b/README.md index 894b5b2..c449e5a 100644 --- a/README.md +++ b/README.md @@ -16,9 +16,9 @@ Read more about [SUIT's design principles](https://github.com/suitcss/suit/). * `Button` - [core] The core button component * `is-disabled` - [state] For disabled-state button styles (themes) -N.B. You must also include the `disabled` attribute on `button` and `input` -elements. For `a` elements, you should remove the `href` attribute and prevent -JavaScript event handlers from firing. +N.B. You must also include the `disabled` attribute on `button` elements. For +`a` elements, you should remove the `href` attribute and prevent JavaScript +event handlers from firing. ## Configurable variables @@ -38,8 +38,6 @@ extended by any number of additional modifier and state classes. Sign up - - ``` ### Theming / extending diff --git a/button.css b/button.css index 8da7402..3b77a0e 100644 --- a/button.css +++ b/button.css @@ -14,7 +14,7 @@ } /** - * The button classes are best applied to links, buttons, and submit inputs. + * The button classes are best applied to links and buttons. * These components can be used in forms, as calls to action, or as part of the * general UI of the site/app. * @@ -22,39 +22,32 @@ * * Button text * - * */ /** - * 1. Corrects inability to style clickable `input` types in iOS. - * 2. Normalize `box-sizing` across all elements that this component could be + * 1. Normalize `box-sizing` across all elements that this component could be * applied to. - * 3. Inherit text color from ancestor. - * 4. Inherit font styles from ancestor. - * 5. Normalize `line-height`. For `input`, it can't be changed from `normal` in Firefox 4+. - * 6. Prevent button text from being selectable. - * 7. Make sure `input` will wrap text across multiple lines. + * 2. Inherit text color from ancestor. + * 3. Inherit font styles from ancestor. + * 4. Prevent button text from being selectable. */ .Button { - -webkit-appearance: none; /* 1 */ background: transparent; border-color: var(border-color-Button); border-style: solid; border-width: var(border-width-Button); - box-sizing: border-box; /* 2 */ - color: var(color-Button); /* 3 */ + box-sizing: border-box; /* 1 */ + color: var(color-Button); /* 2 */ cursor: pointer; display: inline-block; - font: var(font-Button); /* 4 */ - line-height: normal; /* 6 */ + font: var(font-Button); /* 3 */ margin: 0; padding: var(padding-Button); position: relative; text-align: center; text-decoration: none; - user-select: none; /* 6 */ - white-space: normal; /* 7 */ + user-select: none; /* 4 */ } /** diff --git a/test.html b/test.html index d21a01b..81c8113 100644 --- a/test.html +++ b/test.html @@ -35,35 +35,30 @@

renders inline-block

Button text -

inherits font

Button text -

inherits text color

Button text -

allows text wrapping

Button text -

is baseline-aligned

Button text -

.Button.is-disabled

@@ -71,6 +66,5 @@

renders disabled

Button text -