auto allows functions to start after error is passed

[e174596549]

This issue #988 was fixed in async v1.5.1 but still exist in neo-async.

Throw an exception when async.auto calls back with an error Error: async.auto task has cyclic dependencies.

[suguru03]

Thanks for the issue!

I have the test case and can't reproduce it.
Which version are you using? Also, do you have any code to reproduce it?

neo-async/test/controlFlow/test.auto.js

Lines 320 to 334 in 3cfae1d

	it('should stop execution if a synchronous error occur', function(done) {
	async.auto({
	task1: function(callback) {
	callback('error');
	},
	task2: function(callback) {
	assert.ok(false);
	callback();
	}
	}, 1, function(err) {
	assert.strictEqual(err, 'error');
	setTimeout(done, delay);
	});
	});

[e174596549]

neo-async v2.5

const async = require('neo-async');

async.auto({
    task1: function(callback) {
        setTimeout(()=>{callback('error')}, 1000)
    },
    task2: function(callback) {
        setTimeout(()=>{callback(false)}, 2000)
    },
    task3: ['task1', 'task2', function(callback) {
        setTimeout(()=>{callback(false)}, 2000)
    }]
}, function(err) {
    if(err) {
        return console.log('err: ', err)
    }
    console.log('done')
});

/usr/local/bin/node /Users/neo-async-test.js
err:  error
/Users/node_modules/.2.5.0@neo-async/async.js:8167
          throw new Error('async.auto task has cyclic dependencies');
          ^

Error: async.auto task has cyclic dependencies
    at proceedQueue (/Users/node_modules/.2.5.0@neo-async/async.js:8167:17)
    at taskComplete (/Users/node_modules/.2.5.0@neo-async/async.js:8187:7)
    at done (/Users/node_modules/.2.5.0@neo-async/async.js:8153:9)
    at Timeout.setTimeout [as _onTimeout] (/Users/neo-async-test.js:8:25)
    at ontimeout (timers.js:475:11)
    at tryOnTimeout (timers.js:310:5)
    at Timer.listOnTimeout (timers.js:270:5)

async v2.1.4

const async = require('async');

async.auto({
    task1: function(callback) {
        setTimeout(()=>{callback('error')}, 1000)
    },
    task2: function(callback) {
        setTimeout(()=>{callback(false)}, 2000)
    },
    task3: ['task1', 'task2', function(callback) {
        setTimeout(()=>{callback(false)}, 2000)
    }]
}, function(err) {
    if(err) {
        return console.log('err: ', err)
    }
    console.log('done')
});


err:  error

Process finished with exit code 0

[suguru03]

@e174596549
I can reproduce it!
I'll fix it soon, thanks! 😄

[suguru03]

I published it on v2.5.1, could you check it? Thanks! 😸

[e174596549]

This version can be executed correctly. Thanks! 👍🏻