Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with create-react-app #21

Closed
jimgswang opened this issue Aug 25, 2017 · 3 comments
Closed

Incompatible with create-react-app #21

jimgswang opened this issue Aug 25, 2017 · 3 comments
Assignees
Labels

Comments

@jimgswang
Copy link

jimgswang commented Aug 25, 2017

This library is incompatible with create-react-app since it uses UglifyJS2 in it's toolchain, which does not support the destructuring in imports.

Ref terinjokes/gulp-uglify#66

When we try to build our app, we receive

Name expected [./~/aigle/lib/internal/collection.js:3,0][static/js/main.7201b8fd.js:151,6]

create-react-app is the official recommended bootstrap project to create React apps. It is recommended to make this library make this library compatible so we can reach more users.

@suguru03
Copy link
Owner

Thank you for the issue, I'll fix it soon.

@suguru03 suguru03 self-assigned this Aug 25, 2017
@suguru03 suguru03 added the bug label Aug 25, 2017
suguru03 added a commit that referenced this issue Aug 27, 2017
@suguru03
Copy link
Owner

@jimgswang I fixed it and published v1.8.1. Could you check it? :)

@jimgswang
Copy link
Author

It works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants