Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] style overrides #545

Open
vinnyA3 opened this issue Oct 28, 2018 · 1 comment
Open

[bug] style overrides #545

vinnyA3 opened this issue Oct 28, 2018 · 1 comment

Comments

@vinnyA3
Copy link
Contributor

vinnyA3 commented Oct 28, 2018

Description:

The current stylesheet import order is causing style overrides. For example: the bootstrap stylesheet is overriding the the font styling in stylesheet styles1.css.

Solution:

Reorganize the stylesheet import order as such:

<!--Scripts for Carousel-->
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css"/>
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/fontawesome/4.7.0/css/font-awesome.min.css"/>
<link rel="stylesheet" href="style/home/styles1.css" />
<link rel="stylesheet" id="home-styles" href="style/home/home.css" type="text/css" media="all" />

The re-ordering would apply the original styles1.css author's intended font for both headers and paragraph elements. The outcome would appear as follows:

before style import re-order:
before-font-change

after style import re-order:
font-diff

@sudz123 If this change is too drastic, the best option, in my opinion, would be to remove the font-styling in styles1.css (so bootstrap's font gets inherited). I can always open a pull request with the changes upon request, or if someone else would like, they can do so as well.

@guido97
Copy link
Contributor

guido97 commented Oct 30, 2018

fix the override in pull request #590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants