fix: patch bls and bn #1695
Merged
fix: patch bls and bn #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SP1 Performance Test Results Branch: yuwen/patch-curves
|
yuwen01
commented
Oct 24, 2024
|
|
||
| # Example legacy elf | ||
| examples/elf |
There was a problem hiding this comment.
When jonathan made !include_elf, he also manually copied the elf from /target to the workspace root, to maintain backward compatibility with the old !include_bytes method. Let's gitignore that elf in examples.
There was a problem hiding this comment.
Should we gitignore the cargo.lock in examples too?
puma314
approved these changes
Oct 25, 2024
| @@ -71,3 +71,5 @@ sha2-v0-10-6 = { git = "https://github.com/sp1-patches/RustCrypto-hashes", packa | |||
| sha2-v0-9-9 = { git = "https://github.com/sp1-patches/RustCrypto-hashes", package = "sha2", branch = "patch-sha2-v0.9.9" } | |||
| sha2-v0-9-8 = { git = "https://github.com/sp1-patches/RustCrypto-hashes", package = "sha2", branch = "patch-sha2-v0.9.8" } | |||
| tiny-keccak = { git = "https://github.com/sp1-patches/tiny-keccak", branch = "patch-v2.0.2" } | |||
| substrate-bn = { git = "https://github.com/sp1-patches/bn", rev = "43d854d45b5727b1ff2b9f346d728e785bb8395c"} | |||
There was a problem hiding this comment.
nit: we should make this an official tag instead of a random rev?
There was a problem hiding this comment.
agreed i need some kind of admin access to work on that today
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the sp1 program imported the bn and bls patches directly, like
bn = { git = "sp1-patches/bn" }.Now, they import the unpatched version, and the patch is applied from examples/cargo.toml