feat(sdk): network-v2 #1607
Merged
feat(sdk): network-v2 #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattstam
commented
Oct 5, 2024
|
SP1 Performance Test Results Branch: mattstam/network-v2
|
jtguibas
reviewed
Oct 7, 2024
| } | ||
|
|
||
| /// Create a new network client with the given private key. | ||
| pub fn new(private_key: &str) -> Self { |
There was a problem hiding this comment.
this should be the first fn in the impl
jtguibas
reviewed
Oct 7, 2024
crates/sdk/src/network-v2/client.rs
Outdated
| /// Gets the latest nonce for this account's address. | ||
| pub async fn get_nonce(&self) -> Result<u64> { | ||
| let mut rpc = self.get_rpc().await?; | ||
|
|
jtguibas
reviewed
Oct 7, 2024
crates/sdk/src/network-v2/client.rs
Outdated
| let proof = match status { | ||
| ProofStatus::Fulfilled => { | ||
| log::info!("Proof request fulfilled"); | ||
| let proof_uri = res.proof_uri.as_ref().expect("no proof url"); |
There was a problem hiding this comment.
don't use expect in fn that has Result, return err
jtguibas
reviewed
Oct 7, 2024
crates/sdk/src/network-v2/client.rs
Outdated
| let request_body = RequestProofRequestBody { | ||
| nonce, | ||
| // version: version.to_string(), | ||
| version: "sp1-v3.0.0-rc1".to_string(), |
There was a problem hiding this comment.
can this be format!("sp1-{}", SP1_VERSION) which is in lib.rs for core/machine
jtguibas
approved these changes
Oct 8, 2024
jtguibas
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new feature to the sdk,
network-v2, then when on will route requests to the new network RPC.