Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow functions with identical signatures in different extensions to coexist #275

Open
vbarua opened this issue Jun 26, 2024 · 2 comments
Open

Comments

@vbarua
Copy link
Member

vbarua commented Jun 26, 2024

Currently, substrait-java cannot handle functions with identical signatures, even if they are present in different extensions files.

substrait-java should be updated to allow this, as these are technically not duplicate functions.

See substrait-io/substrait#631 for an example of this issue occuring.

@jacques-n
Copy link
Collaborator

Definitely should try to fix this as it's being used as a reason to hold off doing natural things in substrait-io/substrait

@vbarua
Copy link
Member Author

vbarua commented Jul 29, 2024

Actually handling this might be a big change, but if we want to introduce the changes that would break this in substrait it's relatively straightforward to add a workaround hack into substrait-java to exclude duplicated definitions. Effectively, when we build the default extension we would have a blocklist of certain extension that we we would ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants