feat: use Immutables for Argument subclasses #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allows for equality comparisons of Argument subclass BREAKING CHANGE: EnumArgument, TypeArgument and ValueArgument are now abstract
|
I was trying to compare plans and noticed that the Argument subclasses didn't implement equals. Updated them to use Immutable like everything else in the file uses. Determined required fields based on: |
EpsilonPrime
approved these changes
Sep 14, 2023
ajegou
pushed a commit
to ajegou/substrait-java
that referenced
this pull request
Mar 29, 2024
allows for equality comparisons of Argument subclasses BREAKING CHANGE: EnumArgument, TypeArgument and ValueArgument are now abstract
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows for equality comparisons of Argument subclasses
BREAKING CHANGE: EnumArgument, TypeArgument and ValueArgument are now abstract