Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate problematic document. #78

Open
michael opened this issue Jun 9, 2015 · 3 comments
Open

Investigate problematic document. #78

michael opened this issue Jun 9, 2015 · 3 comments

Comments

@michael
Copy link
Member

michael commented Jun 9, 2015

See: data/problematic_document.js.

Search for "00:47:16" and find out what is wrong with that paragraph.

@michael
Copy link
Member Author

michael commented Jun 11, 2015

I know what the problem is. There are some annotations that have startOffset > endOffset. And it screws up the annotator so we get a wrong rendering.

    entity_reference_1f274a52cefc5d64024f6eb926569638: {
      id: "entity_reference_1f274a52cefc5d64024f6eb926569638",
      startOffset: 59,
      endOffset: 44,
      path: [
        "textff1951ba68a8ecce8a9eb55c60951743",
        "content"
      ],
      target: "554a831226ee98fc05606b2a",
      type: "entity_reference"
    },

Will talk with Oliver about a strategy how we can make the editor robust about that thing. I still think the cause of this inconsistency is a paste (including annotations). Maybe you can try to paste around text that has entity references and see if you can break it in a similar way. I didn't manage with my attempts yet.

@michael
Copy link
Member Author

michael commented Jun 11, 2015

Oh and you could solve this by running a script that flips all startOffset endOffset props when they are in wrong order.

@Integral
Copy link
Member

Good catch! I have added this to document's validator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants