Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to turn off deduping #1581

Merged
1 commit merged into from
Jul 25, 2016
Merged

Add option to turn off deduping #1581

1 commit merged into from
Jul 25, 2016

Conversation

ganemone
Copy link
Contributor

No description provided.

@sindresorhus
Copy link

You should probably elaborate on why.

@ganemone
Copy link
Contributor Author

What initially prompted me to do this was an issue with the livereactload library and things being incorrectly deduped. In general though, I think it is useful for debugging. Deduping is not an easy thing to do (just look at npm3 for example). When weird things are happening with builds, it would be useful to be able to turn off deduping to help diagnose/isolate the issue.

@ganemone ganemone closed this Jun 29, 2016
@ganemone ganemone reopened this Jul 6, 2016
@ganemone
Copy link
Contributor Author

ganemone commented Jul 6, 2016

Sorry! I think I accidentally closed the PR when I commented on it last time. Still interested in getting this merged if it looks good.

@ghost
Copy link

ghost commented Jul 6, 2016

This patch looks good to me, it merely exposes features that are already available in sub-modules.

@ghost ghost merged commit 7fbaee2 into browserify:master Jul 25, 2016
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants