Windows compatibility #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it was saying `EventEmitter.require` in the stack traces; now it says `Wrap.require`.
On Windows paths have backslashes, instead of forward slashes.
Previous substitutions had made them always IDs. If it's an absolute path, use `path.normalize` to revert them back to paths.
The existing logic was turning '/node_modules/jade/lib/jade.js' into 'C:\node_modules\jade\lib\jade.js', when '/node_modules/jade/lib/jade.js' was desired. Fixes Jade tests.
.js files aren't valid Win32 applications. It should spawn `node`, with the .js file as an argument.
Have to use `fs.watch` instead of `fs.watchFile`. Tests still do not pass due to "Cannot find module './a'". So not sure if this was a good idea.
ghost
merged commit 
|
The failing watch test was just from treating |
|
Thanks for all the hard work, @domenic! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #113, #125, #126, #137, and #144.
82/83 tests pass.
test/watch.jsis the failure, with "Cannot find module './a'" I am not sure what this is about.Please consider merging. I am happy to make any changes you desire to make it more merge-able.