Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD changes can’t easily be tested in the operator #2857

Open
skitt opened this issue Oct 25, 2023 · 4 comments
Open

CRD changes can’t easily be tested in the operator #2857

skitt opened this issue Oct 25, 2023 · 4 comments
Labels
bug Something isn't working priority:low stale

Comments

@skitt
Copy link
Member

skitt commented Oct 25, 2023

CRD changes to the types managed by the operator can’t easily be tested because the CRDs are installed by subctl. The version of subctl used notably in operator E2E isn’t rebuilt with the version of the operator being tested, so it doesn’t have the CRD changes (or RBAC etc.).

One possible fix for this (other than rebuilding subctl — which isn’t great because it means the operator project has knowledge of a specific dependent) would be to update the CRDs using the operator versions after initial deployment.

@skitt skitt added the bug Something isn't working label Oct 25, 2023
Copy link

github-actions bot commented Mar 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 7, 2024
@dfarrell07 dfarrell07 removed the stale label Mar 12, 2024
@dfarrell07
Copy link
Member

Talking about this on the scrub, it doesn't seem like this would do a lot to help with RBAC (which is what changes most frequently). The project where the RBAC is actually used, say Submariner's main repo, would still need a second PR after the RBAC changes to actually test them where they are used.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further
activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:low stale
Projects
Status: Backlog
Development

No branches or pull requests

2 participants