Add GHA to run MCS conformance tests #1642
Draft
+38
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Created branch: z_pr1642/tpantelis/conformance_gha |
|
The |
tpantelis
force-pushed
the
conformance_gha
branch
15 times, most recently
from
e809a51
to
c45b7c3
Compare
tpantelis
force-pushed
the
conformance_gha
branch
4 times, most recently
from
af53279
to
3e20d12
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
The GHA clones the "sigs.k8s.io/mcs-api" repo with the desired commit and runs `go test` directly in the directory. "v0.1.0" doesn't have the conformance tests so we can't run them via Go import and trying to import a later commit is problematic due incompatible changes to the MCS APIs. Also the conformance tests are really tied to the MCS spec and not specifically to the API version so they'll likely evolve separately anyway. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
conformance_gha
branch
from
3e20d12
to
78d941e
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GHA clones the sigs.k8s.io/mcs-api repo with the desired commit and runs
go testdirectly in the directory. v0.1.0 doesn't have the conformance tests so we can't run them via Go import and trying to import a later commit is problematic due incompatible changes to the MCS APIs. Also the conformance tests are really tied to the MCS spec and not specifically to the API version so they'll likely evolve separately anyway.Fixes #1630