Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze and update subctl diagnose as per the new implementation #192

Closed
Tracked by #186
aswinsuryan opened this issue Apr 27, 2023 · 2 comments
Closed
Tracked by #186

Comments

@aswinsuryan
Copy link
Contributor

aswinsuryan commented Apr 27, 2023

Analyze and update subctl diagnose as per the new implementation as per the new changes.

@vthapar
Copy link
Contributor

vthapar commented Aug 30, 2023

submariner-io/subctl#883 Should have addressed all changes, mainly removal of networkplugin syncer bits. There is no other code in diagnose impacted by these changes.

submariner-io/subctl#888 should take care of subctl gather changes.

@vthapar
Copy link
Contributor

vthapar commented Sep 11, 2023

As of now nothing else needs to be done for this, so closing as complete.

@vthapar vthapar closed this as completed Sep 11, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Submariner 0.16 Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants