You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think enabling servers on syntax test files only cause (linting) issues. Only very few ones (e.g., LSP-copilot) will work well. By suggested rules, the name of a syntax test file starts with syntax_test_ (but in Default/run_syntax_tests.py, it finds filenames start with syntax_test).
The same reason for disabling for SublimeREPL views. See sublimelsp/LSP-pyright#343
A SublimeREPL view has the view setting "repl": True,.
I'm not sure whether view.settings().get("repl") would be a good approach; LSP currently registers new (non-file) views in on_activated_async. Dependent on how/when exactly SublimeREPL writes this setting, this approach might be prone to a race condition, i.e. whether this setting is set or read first.
In general, if we want to have this, I would probably prefer a more general setting name like for example lsp_ignore which would not be specific to SublimeREPL.
Edit: Probably a better approach would be for SublimeREPL to provide its own syntax definition with base scope e.g. source.python.repl, and then exclude this scope in Pyright etc. ("selector": "source.python - source.python.repl"). This way users could also easily configure their own syntax specific settings for REPL views.
TL;DR
By default, disable servers for
Description
I think enabling servers on syntax test files only cause (linting) issues. Only very few ones (e.g., LSP-copilot) will work well. By suggested rules, the name of a syntax test file starts with
syntax_test_
(but inDefault/run_syntax_tests.py
, it finds filenames start withsyntax_test
).The same reason for disabling for SublimeREPL views. See sublimelsp/LSP-pyright#343
A SublimeREPL view has the view setting
"repl": True,
.Suggestion
Something equivalent to
The text was updated successfully, but these errors were encountered: