Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CNumerics to CSpatialScheme #81

Closed
aniketaranake opened this issue Oct 1, 2014 · 2 comments
Closed

Rename CNumerics to CSpatialScheme #81

aniketaranake opened this issue Oct 1, 2014 · 2 comments

Comments

@aniketaranake
Copy link
Member

The word "numerics" applies to most of what SU2 does including time integration. For this reason, a class called CNumerics that only relates to spatial discretization is confusing.

Considering the routines which inherit from this parent class (CUpwRoe_Flow, CAvgGradCorrected_Flow, etc.), I suggest as a new name CSpatialSchemes
@WallyMaier
Copy link
Contributor

@economon is this still something we should pursue? If so, I can work on it.

@economon
Copy link
Member

This is related to #691. Perhaps we can bring any renaming there for discussion, including the potential division of files.

@WallyMaier WallyMaier mentioned this issue Jun 13, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@economon @aniketaranake @WallyMaier