Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulating Gusts in 3D #1319

Closed
mandralis opened this issue Jun 30, 2021 · 4 comments
Closed

Simulating Gusts in 3D #1319

mandralis opened this issue Jun 30, 2021 · 4 comments

Comments

@mandralis
Copy link

Hi all,

I recently discovered the Gust simulation capabilities of SU2 for two-dimensional Euler flows.

I am trying to implement the additional terms necessary for extending the method to 3D Navier-Stokes flows.

I am running into trouble when trying to implement the changes necessary to achieve this.

For now, I have began working on the two functions responsible for the gust simulations:

  1. SU2/SU2_CFD/src/iteration_structure.cpp::CFluidIteration::SetWind_GustField
  2. SU2/SU2_CFD/src/numerics/flow/flow_sources.cpp::CSourceWindGust::ComputeResidual

From what I understand the extension to 3D should simply consist in modifying the function SetWind_GustField to impose a 3D grid-velocity instead of a 2D grid velocity, and adding the appropriate source terms in the function CSourceWindGust (these can even be set to zero, just to debug the code).

However, when I try to implement these changes, I get a segmentation fault that I cannot identify.

Does someone have an idea on how to implement this feature successfully ?

PS: I have attached the modifications I made to the two functions mentioned above here:
SetWind_GustField.txt
ComputeResidual.txt

@pcarruscag
Copy link
Member

Hello,
I think @bigfooted tried to implement the 3D version, this is in the develop branch now.
We have developer meetings every Wednesday at 3pm UK https://meet.jit.si/SU2_DevMeeting to discuss this type of issue.
Join if you can.

@mandralis
Copy link
Author

mandralis commented Jun 30, 2021

Hi,
Thanks for your response ! I will join the developer meeting today - see you then.
Best,
Ioannis

@bigfooted
Copy link
Contributor

Maybe you can create a feature branch with this added feature so we can reproduce the crash and (help you) debug it.

@stale stale bot added the stale label Sep 6, 2021
@su2code su2code deleted a comment from stale bot Sep 19, 2021
@stale stale bot removed the stale label Sep 19, 2021
@pcarruscag
Copy link
Member

Were you able to implement the 3D gusts @mandralis? I recall some issue you mentioned with a segfault.

@stale stale bot added the stale label Mar 2, 2022
@su2code su2code deleted a comment from stale bot Mar 2, 2022
@stale stale bot removed the stale label Mar 2, 2022
@stale stale bot added the stale label May 2, 2022
@su2code su2code deleted a comment from stale bot May 2, 2022
@stale stale bot removed the stale label May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants