Add except: ["after-same-name"] option to at-rule-empty-line-before #2225
Conversation
hudochenkov
force-pushed
the
after-same-name
branch
2 times, most recently
from
34f9507 to
5d7f744
Compare
There was a problem hiding this comment.
@hudochenkov Thanks!
Besides one very minor request, looks great to me!
| @@ -31,6 +31,7 @@ const rule = function (expectation, options) { | |||
| "blockless-after-same-name-blockless", | |||
| "blockless-group", | |||
| "first-nested", | |||
| "after-same-name", | |||
There was a problem hiding this comment.
These options should be in alphabetical order
Options should be order alphabetically within the docs, as it's simpler to maintain that consistency across READMEs than any other system.
Nope, we only add options once there has been a real-world request for it rather than preemptively adding them. |
hudochenkov
force-pushed
the
after-same-name
branch
from
5d7f744 to
c69bbd4
Compare
|
Done. |
| @@ -100,6 +101,8 @@ const rule = function (expectation, options) { | |||
|
|
|||
| // Optionally reverse the expectation if any exceptions apply | |||
| if ( | |||
| || optionsMatches(options, "except", "after-same-name") | |||
There was a problem hiding this comment.
I think your syntax is wrong here.
There was a problem hiding this comment.
Sorry about that. It's fixed now.
hudochenkov
force-pushed
the
after-same-name
branch
from
c69bbd4 to
bafcbc9
Compare
@hudochenkov Thanks! I'm going to wait on the outcome of #2231 before merging. Feel free to add your thoughts to that discussion. We've a much better grasp of what options are needed than we had a few months ago and |
|
Merging as per #2231 (comment) |
|
@hudochenkov Thanks! Changelog
|
#2211
Maybe
"after-same-name"should be placed before"blockless-after-same-name-blockless"in docs, because of its broader nature?Should I add
ignore: ["after-same-name"]also?