Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rules #2124

Closed
15 tasks done
jeddy3 opened this issue Nov 26, 2016 · 14 comments
Closed
15 tasks done

Remove rules #2124

jeddy3 opened this issue Nov 26, 2016 · 14 comments
Assignees
Labels
status: ready to implement is ready to be worked on by someone
Milestone

Comments

@jeddy3
Copy link
Member

jeddy3 commented Nov 26, 2016

  • block-no-single-line
  • custom-property-no-outside-root
  • declaration-block-no-ignored-properties
  • declaration-block-properties-order
  • media-feature-no-missing-punctuation
  • no-browser-hacks
  • no-indistinguishable-colors
  • no-unsupported-browser-features
  • root-no-standard-properties
  • rule-nested-empty-line-before
  • rule-non-nested-empty-line-before
  • selector-no-empty
  • selector-root-no-composition
  • stylelint-disable-reason
  • time-no-imperceptible
@jeddy3 jeddy3 added status: ready to implement is ready to be worked on by someone type: enhancement labels Nov 26, 2016
@jeddy3 jeddy3 added this to the 8.0.0 milestone Nov 26, 2016
@m-allanson
Copy link
Member

Refs #2123 and its associated PR.

@m-allanson m-allanson self-assigned this Jan 23, 2017
@ai
Copy link
Member

ai commented Jan 25, 2017

@davidtheclark why you want to remove no-unsupported-browser-features and no-indistinguishable-colors?

People really afraid to use new tools. They will just ignore doiuse and other PostCSS based tools.

@hudochenkov
Copy link
Member

@ai #2222

@sinedied
Copy link

sinedied commented Feb 6, 2017

It would be better to provide an upgrade path for users currently using no-unsupported-browser-features in their projects (like mine), like providing a plugin with the same functionality instead of directly removing it, don't you think?

EDIT: doiuse cannot be a direct replacement, as AFAIK it does not support sass where stylelint do.

@hudochenkov
Copy link
Member

@sinedied it would be better. That's why we inform community about these changes and ask them to make a plugin if they still need these rules.

@sinedied
Copy link

sinedied commented Feb 6, 2017

@hudochenkov but since you already have it working in current version, why don't you extract the current code in a plugin already and search for a new maintainer instead of hoping that someone will rewrite the whole thing?

@hudochenkov
Copy link
Member

@sinedied Courage™! We have reasons to exclude no-unsupported-browser-features #2222 We give an opportunity to a brave person in the stylelint community to create a plugin, which helps other people. While we can focus on stylelint to make it better.

@jeddy3
Copy link
Member Author

jeddy3 commented Feb 6, 2017

give an opportunity to a brave person in the stylelint community to create a plugin

@sinedied It sounds like you use the no-unsupported-browser-features rule. Would you like to be that person and champion this plugin? As you said, it would just be a case of extracting the rule code into a plugin to begin with. As you currently make use of the rule you're an ideal candidate for maintaining it and pushing it forward with exciting new features. It would be a great help to the stylelint community.

@davidtheclark
Copy link
Contributor

@sinedied Just to be clear: anybody can extract the current code into a plugin — nobody has to rewrite the whole thing or any part if they don't want to. Open source!

@sinedied
Copy link

sinedied commented Feb 6, 2017

Sure, anybody can extract the source, but surely understanding it is another matter, I bet someone from the stylelint team can pull it out in less time that I would need to just get started with it, that was my point.

@jeddy3
Copy link
Member Author

jeddy3 commented Feb 7, 2017

@stylelint/core FYI, @m-allanson and I just brought the v8 branch up-to-date with master. Therefore the issues in the 8.0 milestone are ready to be tackled. Assign yourself and label as status: wip if any of them take your fancy :)

@hudochenkov
Copy link
Member

@m-allanson Would you remove deprecated rules? Or shall I do this?

Unrelated question: is it ok to merge master into v8 without a PR?

@m-allanson
Copy link
Member

@hudochenkov I will do this soon :)

Yes I think it's ok to merge master into v8 without a PR.

@jeddy3
Copy link
Member Author

jeddy3 commented Mar 19, 2017

Done in #2422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready to implement is ready to be worked on by someone
Development

No branches or pull requests

6 participants