Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore declaration-block-single-line-max-declarations removed on 30.0.0 #285

Closed
elirasza opened this issue Apr 1, 2023 · 2 comments · Fixed by #288
Closed

Restore declaration-block-single-line-max-declarations removed on 30.0.0 #285

elirasza opened this issue Apr 1, 2023 · 2 comments · Fixed by #288
Assignees
Labels
status: wip is being worked on by someone type: bug a problem with a feature or rule

Comments

@elirasza
Copy link

elirasza commented Apr 1, 2023

What steps are needed to reproduce the bug?

Upgrade from 29.0.0 to 30.0.0

What did you expect to happen?

The declaration-block-single-line-max-declarations rule should have still been present

What actually happened?

In the changelog regarding 30.0.0, it is said 64 rules were removed because they are now deprecated by stylelint. I noticed one of them, declaration-block-single-line-max-declarations, does not seem to be in the deprecation list. Is this an error ? Or was its removal on purpose, but for another reason than deprecation ?

@ybiquitous ybiquitous added the status: needs discussion triage needs further discussion label Apr 2, 2023
@ybiquitous
Copy link
Member

@elirasza Thanks for the report. As you pointed, the declaration-block-single-line-max-declarations rule is not about a stylistic convention and so not deprecated. The rule is categorized in Max & min.

I guess the rule was accidentally removed since the original issue about this deprecation (stylelint/stylelint#5674) didn't mention this rule.

Restoring the rule sounds good to me for now, but I'd like to hear others' opinions. If nobody has objections, let's restore it.

By the way, there seems to be no problem in the case when used with Prettier together since Prettier formats a single line to multiple lines.

@ybiquitous
Copy link
Member

ybiquitous commented Apr 2, 2023

FYI. The rule was removed with PR #277.

@ybiquitous ybiquitous added status: wip is being worked on by someone type: bug a problem with a feature or rule and removed status: needs discussion triage needs further discussion labels Apr 16, 2023
@ybiquitous ybiquitous self-assigned this Apr 16, 2023
@ybiquitous ybiquitous changed the title Removed declaration-block-single-line-max-declarations should have stayed Restore declaration-block-single-line-max-declarations removed on 30.0.0 Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: wip is being worked on by someone type: bug a problem with a feature or rule
Development

Successfully merging a pull request may close this issue.

2 participants