This repository has been archived by the owner on Oct 16, 2024. It is now read-only.
Fix renaming bug where there were 2 patterns #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kienstra
commented
Feb 20, 2023
| @@ -110,8 +109,8 @@ function save_metadata_to_pattern_file( $override, $post_id, $meta_key, $meta_va | |||
| ] | |||
| ); | |||
|
|
|||
| if ( $previous_value && $previous_value !== $meta_value ) { | |||
| delete_pattern( $meta_value ); | |||
| if ( $pattern_name !== $meta_value ) { | |||
There was a problem hiding this comment.
$pattern_name is a more reliable previous pattern name. Every time we're in the editor, there will be a pm_pattern post with a ->post_title (the pattern name).
kienstra
commented
Feb 20, 2023
| @@ -173,16 +172,13 @@ function redirect_pattern_actions() { | |||
| } | |||
|
|
|||
| if ( 'edit-pattern' === filter_input( INPUT_GET, 'action' ) ) { | |||
| // Prevent the hook from overwriting the file when this post is created. | |||
| remove_action( 'rest_after_insert_pm_pattern', __NAMESPACE__ . '\save_pattern_to_file' ); | |||
There was a problem hiding this comment.
Unrelated, but removes a hack I added that's not needed anymore, thanks to Phil's rest_insert_ hook.
kienstra
commented
Feb 20, 2023
| if ( $previous_value && $previous_value !== $meta_value ) { | ||
| delete_pattern( $meta_value ); | ||
| if ( $pattern_name !== $meta_value ) { | ||
| delete_pattern( $pattern_name ); |
There was a problem hiding this comment.
This was the bug (which I created).
$meta_value was the new pattern name, where it should have deleted the old name.
johnstonphilip
approved these changes
Feb 21, 2023
|
Thanks a lot, @johnstonphilip! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Renaming (changing the title) of a pattern resulted in 2 patterns. One pattern with the new name, and a pattern with the old name.
After
This deletes the pattern with the old name.
Fixes part of #57 (Renaming a pattern creates a new copy)
How to test
patterns/directory only has a pattern with the new name, not the old name: