Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In some instances GSS or WP ignores sidebar id and uses the title: #21

Open
jaygidwitz opened this issue Mar 7, 2017 · 0 comments
Open

Comments

@jaygidwitz
Copy link

Split off from #11 (comment)

What is happening now:

I made a Genesis Simple Sidebar named Sidebar. (That's my creative side.)

I left the id blank. So an id of gss-sidebar-1 was generated.

Now whenever I add a widget to this sidebar it also is added to the primary sidebar with and id of sidebar

screenshot 2017-03-06 14 12 13

Noting that I was not able to replicate this with other sidebars subsequently.

Testing if this a preexisting bug in Production:

  • I cannot replicate exactly b/c when I do this with the production plugin I get the error that this issue is meant to solve.
  • When I create a new sidebar with gss 2.0.4 & name the sidebar Sidebar and give it an id of sidebar even though there is an existing sidebar with that name, then the gss sidebar replaces that one.
  • So this may be somewhat preexisting.

I was able to replicate this again with the develop plugin but following the above instructions on a different wp install.

Creating a sidebar manually with the same specs gives the same result:

Name => Sidebar
ID => gss-sidebar-1

screenshot 2017-03-06 15 23 56

Nathan's comments:

OK, let's get this into another issue. It might not even be fixable. Seems like WordPress basically ignores the ID and is using the Title in some instances. I'll have to investigate. But this shouldn't hold back a release, IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant