Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update e2e tests for WP 5.8 #87

Merged
merged 15 commits into from
Aug 25, 2021
Merged

Update e2e tests for WP 5.8 #87

merged 15 commits into from
Aug 25, 2021

Conversation

kienstra
Copy link
Contributor

@kienstra kienstra commented Aug 3, 2021 •
edited
Loading

Changes

  • Ensure e2e tests works with WP 5.8
  • Update @wordpress/e2e-test-utils package

Testing instructions

  • Just a sanity check, please. No functional testing needed.

@kienstra kienstra mentioned this pull request Aug 6, 2021
Merged
@kienstra
Add an id to the <Button> components
c3f6eb2 
So it can get them via
getByLabelText(),
and it's more meaningful to users.
@kienstra
Simplify <GcbInspector> by removing fields const
e714467 
It's not necessary to store it in fields,
then render it right below.
@kienstra
Do composer update after installing the phpunit
c44861b 
There was an error in CI
from needed to do composer update.
@kienstra
Remove needless key prop
f913f9a 
This isn't in an array,
so it shouldn't be needed.
@kienstra
Run composer update for WordPress, not this plugin
262d8e1
@kienstra
Remove <DropZoneProvider>, as it's deprecated
5ceac51 
Also, we're using exact npm package versions,
so we should be able to do this.
@kienstra
Bump pptr-testing-library to 0.6.5
2228822
@kienstra
Revert the huge diff in package-lock.json
9086803 
use node 14
instead of 15.
@kienstra
Fix the clientId values for file and image controls
9c981bf 
Those are actually in parentBlockProps,
not in the component props.
@kienstra
Remove the DependencyInjection plugin
ce24b69 
I should have removed this earlier.
This shouldn't be creating asset.php files.
@kienstra
Revert "Remove the DependencyInjection plugin"
bb37365 
This reverts commit ce24b69.
@kienstra
Remove attr object that was attributes spread into a {}
56c8e2b 
This is confusing,
as it shouldn't be necessary to
have attributes and attr.
@kienstra
Copy link
Contributor Author

@dreamwhisper,
Thanks so much!!!

@kienstra kienstra merged commit 84ea385 into develop Aug 25, 2021
@kienstra kienstra deleted the update/e2e-tests-5.8 branch August 25, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamwhisper dreamwhisper dreamwhisper approved these changes

@johnstonphilip johnstonphilip Awaiting requested review from johnstonphilip

@BMO-tech BMO-tech Awaiting requested review from BMO-tech

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kienstra @dreamwhisper