Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the version to 1.3.0 for release #85

Merged
merged 5 commits into from
Jul 19, 2021
Merged

Bump the version to 1.3.0 for release #85

merged 5 commits into from
Jul 19, 2021

Conversation

kienstra
Copy link
Contributor

@kienstra kienstra commented Jul 14, 2021 •
edited
Loading

Changes

  • Bump the version
  • Conditionally use the new 'block_categories_all' filter

Do not merge without #74

Testing instructions

  1. A sanity check of the code
  2. No functional testing needed.

kienstra added 2 commits July 14, 2021 17:01
@kienstra
Use the new category filter, depending on the version
9deac64 
There's a PHP notice in 5.8
for continuing to use
'block_categories'.
But 'block_categories_all' didn't exist
before 5.8.
@kienstra
Bump version, fix one failed PHPUnit test
fa23b76 
Also, add a small Changelog entry,
need to expand on that.
@kienstra
Copy link
Contributor Author

kienstra commented Jul 14, 2021 •
edited
Loading

The e2e tests are passing with 5.8-RC2:

npm run wp-env run cli 'wp core update --version=5.8-RC2'
npm run test:e2e

kienstra added 2 commits July 14, 2021 17:32
@kienstra
Fix PHPUnit error by adding capability later
39039c9 
It looks like it is checking is_admin()
and exiting early from block_post->add_caps().
But I'm not sure how it was passing before.
@kienstra
Add CHANGELOG entried, and a TODO block
3db163b 
Saying that it should delete the conditionals
once they're not necessary.
@kienstra kienstra marked this pull request as ready for review July 19, 2021 15:06
dreamwhisper
dreamwhisper approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@dreamwhisper dreamwhisper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

php bin/verify-versions.php Looks good!

Version references:
{
    "README.md#stable-tag": "1.3.0",
    "genesis-custom-blocks.php#metadata": "1.3.0",
    "package.json": "1.3.0"
}
Success! All of the version numbers are the same, and there's a CHANGELOG.md entry.

@kienstra
Copy link
Contributor Author

Thanks so much, @johnstonphilip and @dreamwhisper!

@kienstra kienstra merged commit 7f31adb into develop Jul 19, 2021
@kienstra kienstra deleted the bump/1.3.0 branch July 19, 2021 21:27
kienstra added a commit that referenced this pull request Jul 20, 2021
@kienstra
Bump WP 'Tested up to' to 5.8, forgot earlier
e798b9e 
This isn't the right PR to do it in,
but I forgot in #85.
@kienstra kienstra mentioned this pull request Jul 20, 2021
Merged
@dreamwhisper dreamwhisper restored the bump/1.3.0 branch July 20, 2021 18:35
@kienstra kienstra deleted the bump/1.3.0 branch July 27, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstonphilip johnstonphilip johnstonphilip approved these changes

@dreamwhisper dreamwhisper dreamwhisper approved these changes

@mikemcalister mikemcalister Awaiting requested review from mikemcalister

@marksabbath marksabbath Awaiting requested review from marksabbath

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kienstra @dreamwhisper @johnstonphilip